GRNET patches #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify a URL (HTTP) and ganeti-instance-image will try to find the image there before looking for a local file. Allows caching an image to the disk. For this feature to work, sha1sum and curl are added as dependencies.
Contributor
Author
|
Forgot to add that the remote image patch doesn't change any default behaviour. So without adding anything to the defaults file, the behaviour should be the same (i.e. read the image from the disk). |
Member
|
@alexkiousis @rowanthorpe I'm closing this pull request in favor of #15 #16 and #17. I'd love to have your input on them if you're interested! I'm closing this pull request for now. Thanks for the patches! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to create a different PR for each feature, but i've already commited them on the same branch. So it's easier to include them together.
The first 2 patches extend ganeti-instance-image's OS API to v20 and add support for basic osparams.
The first patch adds
img_formatandimg_id. This allows specifing the os of the image during instance creation. These parameters are required. The original commit were made byConstantinos Venetsanopoulos <cven@cslab.ece.ntua.gr>on 05-2011. The verify script is new.The second commit adds support for a second osparam (
img_ssh_key_url) and a hook that injects it into the image (for the root user). This was made byApollon Oikonomopoulos <apollon@noc.grnet.gr>on 06-2011. The img_ssh_key_url osparam is not required.The third one was commited by
Nikos Skalkotos <skalkoto@gmail.com>on 05-2011 with the following comment:Forced filesystem relabeling in the initial boot of a Fedora image. This is needed by SELinux in recent Fedora releases, because in any other case, SELinux will consider files that were externally altered by gnt-instance-image scripts as being in a inconsistent state and will not permit the system to use them, causing a denial of service.
The forth one is a new hook that randomizes the generated system crontab. The reasoning is that we don't want all the vms on a node running their crons at the same time to avoid stressing the node. This was written by @fubvr.
The last one is by me. We wanted to centralize the images so we don't have to sync them to every cluster. So this is a feature that enables ganeti-instance-image to fetch a specified image from an HTTP URL. It introduces 4 new options IMAGE_URL, CACHE_DIR, IMG_VERIFY, IMG_CLEANUP and 2 new dependencies:
sha1sumfor image verification andcurlfor the downloading of the images.