perf(linter): switch if !matches!(node.kind(), ...) to match block
#14650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #14650 will not alter performanceComparing Summary
Footnotes
|
graphite-app
bot
changed the base branch from
10-15-perf_linter_rearrange_rules_for_node_type_analysis
to
graphite-base/14650
graphite-app
bot
force-pushed
the
10-16-perf_linter_switch_if_matches_node.kind_._to_match_block
branch
from
cf235ec to
d1868c6
Compare
graphite-app
bot
force-pushed
the
graphite-base/14650
branch
from
46ec4b6 to
f2c33f5
Compare
graphite-app
bot
force-pushed
the
10-16-perf_linter_switch_if_matches_node.kind_._to_match_block
branch
from
d1868c6 to
00e64a8
Compare
camc314
approved these changes
Oct 16, 2025
Merge activity
|
…14650) Adding support for `matches!` in the linter codegen would be somewhat tedious as we'd need to start parsing macros. Instead, there is a similar idiom that we already support: diverging `match` on `node.kind()`. So, I've updated the linter codegen to support `|` in match arms, plus updated rules to use this new pattern instead of `if !matches!(...)`. <img width="1392" height="664" alt="CleanShot 2025-10-16 at 12 12 45@2x" src="https://github.com/user-attachments/assets/75762f93-152a-49e4-83ab-46240d7b2b62" />
graphite-app
bot
force-pushed
the
10-16-perf_linter_switch_if_matches_node.kind_._to_match_block
branch
from
00e64a8 to
400a99a
Compare
graphite-app
bot
deleted the
10-16-perf_linter_switch_if_matches_node.kind_._to_match_block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
matches!in the linter codegen would be somewhat tedious as we'd need to start parsing macros. Instead, there is a similar idiom that we already support: divergingmatchonnode.kind(). So, I've updated the linter codegen to support|in match arms, plus updated rules to use this new pattern instead ofif !matches!(...).