Skip to content

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 16, 2025

Align Prettier's behavior. The biome's implementation missed some nodes to do the same thing.

Copy link
Member Author

Dunqing commented Oct 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Oct 16, 2025

CodSpeed Performance Report

Merging #14659 will improve performances by 3.79%

Comparing 10-16-fix_formatter_should_group_type_parameters_and_parameters_for_method-like_and_function-like_nodes (56e3681) with 10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements (8c67314)

Summary

⚡ 1 improvement
✅ 32 untouched
⏩ 4 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Instrumentation minifier[cal.com.tsx] 36.9 ms 35.6 ms +3.79%

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Contributor

graphite-app bot commented Oct 16, 2025

Merge activity

…d-like and function-like nodes (#14659)

Align Prettier's behavior. The biome's implementation missed some nodes to do the same thing.
@graphite-app graphite-app bot force-pushed the 10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements branch from 8c67314 to 392bf74 Compare October 16, 2025 21:52
@graphite-app graphite-app bot force-pushed the 10-16-fix_formatter_should_group_type_parameters_and_parameters_for_method-like_and_function-like_nodes branch from 56e3681 to 0150ad5 Compare October 16, 2025 21:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 16, 2025
Base automatically changed from 10-16-fix_formatter_improve_handling_of_dangling_comments_in_if_statements to main October 16, 2025 22:03
@graphite-app graphite-app bot merged commit 0150ad5 into main Oct 16, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-16-fix_formatter_should_group_type_parameters_and_parameters_for_method-like_and_function-like_nodes branch October 16, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant