-
Notifications
You must be signed in to change notification settings - Fork 235
feat: add array contains matcher #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxCampman
wants to merge
3
commits into
pact-foundation:master
Choose a base branch
from
MaxCampman:feat-add-array-contains-matcher
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace PactNet.Matchers | ||
| { | ||
| public class ArrayContainsMatcher : IMatcher | ||
adamrodger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| /// <summary> | ||
| /// Type of the matcher | ||
| /// </summary> | ||
| [JsonPropertyName("pact:matcher:type")] | ||
| public string Type => "array-contains"; | ||
|
|
||
| /// <summary> | ||
| /// The items expected to be in the array. | ||
| /// </summary> | ||
| [JsonPropertyName("variants")] | ||
| public dynamic Value { get; } | ||
|
|
||
| /// <summary> | ||
| /// Initialises a new instance of the <see cref="ArrayContainsMatcher"/> class. | ||
| /// </summary> | ||
| /// <param name="variants"></param> | ||
| public ArrayContainsMatcher(dynamic[] variants) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: This passes in an array, but we store the suggestion: Use |
||
| { | ||
| Value = variants; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
tests/PactNet.Abstractions.Tests/Matchers/ArrayContainsMatcherTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| using System.Text.Json; | ||
| using FluentAssertions; | ||
| using PactNet.Matchers; | ||
| using Xunit; | ||
|
|
||
| namespace PactNet.Abstractions.Tests.Matchers | ||
| { | ||
| public class ArrayContainsMatcherTests | ||
| { | ||
| [Fact] | ||
| public void Ctor_String_SerializesCorrectly() | ||
| { | ||
| // Arrange | ||
| var example = new[] | ||
| { | ||
| "Thing1", | ||
| "Thing2", | ||
| }; | ||
|
|
||
| var matcher = new ArrayContainsMatcher(example); | ||
|
|
||
| // Act | ||
| var actual = JsonSerializer.Serialize(matcher); | ||
|
|
||
| // Assert | ||
| actual.Should().Be(@"{""pact:matcher:type"":""array-contains"",""variants"":[""Thing1"",""Thing2""]}"); | ||
adamrodger marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: I think for this example to 'come to life' then we'd really need it to match multiple different possible variants
Perhaps if there were different order types or something so that they could have different fields on them, then the matching rules could reflect those variants. Like a fulfilled order has an extra date on it for when it was completed, or something like that.