Skip to content

Excavator: [Action Required] Fix Safety annotations to avoid SDIs #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+0 −4
Closed

Excavator: [Action Required] Fix Safety annotations to avoid SDIs #1363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions idea-plugin/src/main/java/com/palantir/javaformat/intellij/FormatterProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ Optional<FormatterService> get(Project project, PalantirJavaFormatSettings setti
settings.injectedVersionIsOutdated()));
}

@SuppressWarnings("for-rollout:Slf4jLogsafeArgs")
private static Optional<FormatterService> createFormatter(FormatterCacheKey cacheKey) {
if (cacheKey.nativeImageClassPath.isPresent()) {
log.info("Using the native formatter with classpath: {}", cacheKey.nativeImageClassPath.get());
Expand Down Expand Up @@ -120,7 +119,6 @@ private static List<Path> getProvidedImplementationUrls(List<URI> implementation
return implementationClasspath.stream().map(Path::of).collect(Collectors.toList());
}

@SuppressWarnings("for-rollout:Slf4jLogsafeArgs")
private static List<Path> getBundledImplementationUrls() {
// Load from the jars bundled with the plugin.
IdeaPluginDescriptor ourPlugin = getPluginDescriptor();
Expand All @@ -129,7 +127,6 @@ private static List<Path> getBundledImplementationUrls() {
return listDirAsUrlsUnchecked(implDir);
}

@SuppressWarnings("for-rollout:Slf4jLogsafeArgs")
private static List<Path> getImplementationUrls(
Optional<List<URI>> implementationClassPath, boolean useBundledImplementation) {
if (useBundledImplementation) {
Expand Down Expand Up @@ -177,7 +174,6 @@ private static OptionalInt parseSdkJavaVersion(Sdk sdk) {
return parseSdkJavaVersion(version);
}

@SuppressWarnings("for-rollout:Slf4jLogsafeArgs")
@VisibleForTesting
static OptionalInt parseSdkJavaVersion(String version) {
int indexOfVersionDelimiter = version.indexOf('.');
Expand Down