Support raw SQL Alchemy #75
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #71.
It adds a new argument
sqlalchemy_engine
toDebugToolbarExtension(app, sqlalchemy_engine=None)
. If no engine is passed, the old behavior is maintained. If an engine is passed, then the query recording events are installed on that engine and noflask-sqlalchemy
db
is touched. The event registration still uses flask-sqlalchemy code.This still requires
flask-sqlalchemy
to be installed in order to record queries, but it does not require the user to use it to declare models and query for data; raw sqlalchemy engines and tables can be used instead. I added a basic app example that uses plain sql alchemy underbasic_app_raw_sqlalchemy.py