Skip to content

suggested changes for mouse position how to from discord #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.11
Choose a base branch
from
Open

suggested changes for mouse position how to from discord #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions programming/hardware-support/mouse-support.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ To get the position:

.. code-block:: python

if base.mouseWatcherNode.hasMouse():
x = base.mouseWatcherNode.getMouseX()
y = base.mouseWatcherNode.getMouseY()
pointer = base.win.get_pointer(0)
if pointer.in_window:
mouseX = pointer.get_x()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indent, needs another space on this line

Let's encourage pointer.x and pointer.y instead

Variable names should be all-lower-caps, so use mouse_x and mouse_y (or just x and y as in the original)

mouseY = pointer.get_y()

.. only:: cpp

Expand Down