BUG: Fix .rolling().mean() returning NaNs on reassignment (#61841) #61846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue #61841 where
.rolling().mean()
unexpectedly returns all NaNs when the same assignment is executed more than once, even with.copy()
used on the DataFrame.Problem
When using:
Only the first assignment works as expected. The second assignment results in a column full of NaNs. This bug is caused by slicing the output with
[:: self.step]
inside_apply_columnwise()
, which alters the result's shape and breaks alignment during reassignment.Fix
This PR removes the problematic slicing from
_apply_columnwise()
:Before (buggy):
After (fixed):
This change:
.rolling().mean()
works even on repeated assignmentTesting
Reproduced and verified the fix using both real-world and synthetic data:
Notes
main
without this patch.Let me know if anything needs improvement. Thanks for reviewing!
