-
-
Notifications
You must be signed in to change notification settings - Fork 18.8k
BUG: Fix TypeError in assert_index_equal when comparing CategoricalIndex with check_categorical=True and exact=False #61941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aniketsy
wants to merge
13
commits into
pandas-dev:main
Choose a base branch
from
Aniketsy:bugfix-assert-categoricalindex-typeerror
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
085caa1
BUG: Fix TypeError in assert_index_equal when comparing CategoricalIn…
Aniketsy c0427e6
STYLE: Fix E501 line too long in assert_index_equal error message
Aniketsy db54fad
TST: Add test case for categorical index assertion fix
Aniketsy 5edf8ce
BUG: Fix (GH#61941) and unit test
Aniketsy 2b6d3a0
Add unit test and (GH#61941)
Aniketsy 08739f2
Add unit test and (GH#61941)
Aniketsy ddf650e
Add unit test and (GH#61941)
Aniketsy 3f998d4
TST: Fix formatting in test_assert_index_equal (via pre-commit)
Aniketsy 4cc4e77
style: fix formatting with pre-commit (Ruff)
Aniketsy f9f62a3
Fix: Check fail
Aniketsy 5d5d668
TST: Add test for CategoricalIndex vs Index in assert_index_equal
Aniketsy 459298d
TST: Use isinstance for CategoricalIndex in assert_index_equal
Aniketsy ecaeb64
Use the public .codes property for internal comparison of Categorical…
Aniketsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use
isinstance
checks to call_internal_get_values
if the object is aCategoricalIndex
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou ! for correcting me . I have updated that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one check fail due to:
CategoricalIndex does not have an _internal_get_values() method.
So should i use .value or something else . Please suggest