-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
DOC: added button to edit on GitHub #61956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
hey @afeld, could you take a look at this? TIA! |
/preview |
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/61956/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks but the links do not direct to editable pages e.g. the edit link in https://pandas.pydata.org/preview/pandas-dev/pandas/61956/docs/
It seems that’s the only page that isn’t working. Sorry, but could you explain how |
Ah OK, yes I see this works for some straightforward Yes ideally we would only only want this button on pages that are not templates or API pages. Is there a straightforward way in pydata-sphinx-theme to only add this button to select pages? |
Sadly, there is no straightforward way to exclude some pages. But, I am gonna try to make a extension for this (might take some time as I am new to sphinx lol). |
Ok, so I added a new list called exclude_edit_page_button and it will exclude adding the button to those pages. But, I have some questions:
|
|
…or not based on the config
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.