MNT: migrate from codecs.open to open #62073
Merged
+6
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
commented
Aug 8, 2025
| @@ -513,19 +513,18 @@ def test_is_fsspec_url_chained(): | |||
| assert not icom.is_fsspec_url("filecache::://pandas/test.csv") | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("encoding", [None, "utf-8"]) | |||
There was a problem hiding this comment.
I could also keep testing this but CPython warns about using open(..., encoding=None): EncodingWarning: 'encoding' argument not specified. In this case we are explicitly specifying None but I don't think CPython can tell the difference.
ngoldbaum
commented
Aug 8, 2025
| @@ -143,7 +142,7 @@ def show_versions(as_json: str | bool = False) -> None: | |||
| sys.stdout.writelines(json.dumps(j, indent=2)) | |||
| else: | |||
| assert isinstance(as_json, str) # needed for mypy | |||
| with codecs.open(as_json, "wb", encoding="utf8") as f: | |||
| with open(as_json, "w", encoding="utf-8") as f: | |||
There was a problem hiding this comment.
I changed it from "wb" to "w" because I think the "b" here is a bug (bytes and utf-8???)
mroeschke
approved these changes
Aug 8, 2025
|
Thanks @ngoldbaum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #61950, towards supporting Python 3.14
See the 3.14 deprecations and python/cpython#133036 for more details.
There is one spot that was nontrivial - the use in
pandas.util._print_versionsI think was buggy - it wanted to write a file in bytes mode and also specified an encoding.codecs.opendidn't blink at this but regularopenis more restrictive. I think what I updated it to is correct and this is a latent bug, probably introduced a long time ago in the 2->3 transition.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.