Add clock phase argument to smartpin SPI object #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followed Rev 5 06-11-2020 Jon Titus, Page 56 of 63 Verified with logic analyser.
|
Thank you, @deets. @JonMcPhalen - can you review the suggested changes and let us know how you'd like to proceed. You can discuss it here or ask questions as well. |
|
I work with an ADS1256 that needs SPI mode 1, and with these adaptions got it working. |
|
@JonMcPhalen - see comments above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed
Rev 5 06-11-2020 Jon Titus, Page 56 of 63
Verified with logic analyser.