Skip to content

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Dec 19, 2024

No description provided.

Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Dec 19, 2024
@mtrezza
Copy link
Member Author

mtrezza commented Dec 19, 2024

BREAKING CHANGE: Removes support for .NET 6.0, 7.0 as they have reached their end-of-life date.

@mtrezza mtrezza force-pushed the feat/remove-support-for-outdated-net branch from 0764997 to 34db672 Compare December 20, 2024 00:24
@YBTopaz8
Copy link
Member

When this passes. My new Request will to.
I only Target .NET 6 as per your suggestion.
After you merge this, my PR should work.

Alternatively, you can accommodate for the request only as well.
I'll be here if there's anything i should do.

@mtrezza
Copy link
Member Author

mtrezza commented Dec 21, 2024

With this PR we'll target .NET 8 as the new min. version. This is currently on hold until the other PRs are merged, so that anyone still using .NET 6 or 7 can benefit from as many fixes in #402 as possible. If there are parts of the PR that are require min .NET 8, we'll merge them after this PR. That's a good example for why it would be great if you could split #40 into individual PRs.

@YBTopaz8
Copy link
Member

YBTopaz8 commented Dec 21, 2024

Done.
I fundamentally did 3 things

  1. Fixed Tests (log out etc), PR is submitted
  2. Fixed Relations. PR submitted (keep in mind it targets only .NET 6, should i update to only .NET 8?
  3. Added more UT to hopefully increase coverage. Submitted as well !

@mtrezza
Copy link
Member Author

mtrezza commented Dec 21, 2024

That sounds good; as mentioned above, I think we should merge (2) and (3) before this PR if that is easily possible; so you can leave the PR for (2) targeting .NET 6.

@mtrezza
Copy link
Member Author

mtrezza commented Mar 6, 2025

@YBTopaz8 Do you think this is ready for merge?

@YBTopaz8
Copy link
Member

YBTopaz8 commented Mar 6, 2025

It is!

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.20%. Comparing base (9af640a) to head (c28a4ee).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   48.00%   48.20%   +0.19%     
==========================================
  Files         106      106              
  Lines        6199     6199              
  Branches      950      950              
==========================================
+ Hits         2976     2988      +12     
+ Misses       2910     2907       -3     
+ Partials      313      304       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@YBTopaz8
Copy link
Member

YBTopaz8 commented Mar 6, 2025

48% code coverage? Great!
I'm doing more tests, will be pushing when done as well

@mtrezza
Copy link
Member Author

mtrezza commented Mar 7, 2025

Great, so merging this now...

@mtrezza mtrezza merged commit 8fa9be9 into parse-community:master Mar 7, 2025
5 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 7, 2025
# [5.0.0](4.0.2...5.0.0) (2025-03-07)

### Features

* Remove support for .NET 6.0, 7.0 ([#396](#396)) ([8fa9be9](8fa9be9))

### BREAKING CHANGES

* Removes support for .NET 6.0, 7.0 as they have reached their end-of-life date. ([8fa9be9](8fa9be9))
@parseplatformorg
Copy link

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 7, 2025
@parse-community parse-community deleted a comment Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants