-
-
Notifications
You must be signed in to change notification settings - Fork 149
chore: update Cargo.toml for release v2.4.2 #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated Cargo.toml manifest: bumped package version to 2.4.2 and refreshed parseable_ui asset URL and SHA-1 to point to the v2.4.2 build. No source code or dependency changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Cargo.toml (1)
161-162
: Please manually verify asset integrity and consider adding automated checks.
- Confirm that the URL
https://parseable-prism-build.s3.us-east-2.amazonaws.com/v2.4.2/build.zip
still responds with HTTP 200 and that its SHA-1 hash equals
218c43d9bb75e8f9a15df544763a874e65fa0f40
.- (Optional) Migrate from SHA-1 to SHA-256 for stronger integrity guarantees.
- (Optional) Add a CI job to fetch the asset, check for HTTP 200, compute its checksum, and fail the build on any mismatch.
- (Optional) Derive these URL and checksum values programmatically in
build.rs
to prevent human errors.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: coverage
- GitHub Check: Build Kafka aarch64-apple-darwin
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "parseable" | |||
version = "2.4.1" | |||
version = "2.4.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version bump to 2.4.2: looks good; please verify repo hygiene (tag/changelog) and metadata cohesion.
- Ensure the git tag v2.4.2, CHANGELOG entry, and release notes are ready and consistent with this bump.
- Sanity-check that the version segment in parseable_ui assets (see Lines 161-162) matches this crate version to avoid drift.
Run this quick consistency check from the repo root:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Extract crate version
CRATE_VERSION="$(rg -nP '^\s*version\s*=\s*"(\d+\.\d+\.\d+)"' -or '$1' Cargo.toml | head -n1)"
echo "Crate version: $CRATE_VERSION"
# 2) Ensure assets-url version segment matches crate version (if metadata exists)
if rg -n '^\s*\[package\.metadata\.parseable_ui\]' Cargo.toml >/dev/null; then
URL_VER="$(rg -nP '^\s*assets-url\s*=\s*".*?/v(\d+\.\d+\.\d+)/' -or '$1' Cargo.toml | head -n1 || true)"
echo "Assets URL version: ${URL_VER:-<not found>}"
if [[ -n "${URL_VER:-}" && "$URL_VER" != "$CRATE_VERSION" ]]; then
echo "ERROR: assets-url version ($URL_VER) != crate version ($CRATE_VERSION)" >&2
exit 1
fi
fi
# 3) Optional: verify CHANGELOG has the version header if a changelog exists
CHANGELOG="$(fd -a -t f -i 'CHANGELOG*' || true)"
if [[ -n "$CHANGELOG" ]]; then
if ! rg -n "^\s*##?\s*\[?$CRATE_VERSION\]?" $CHANGELOG >/dev/null; then
echo "WARN: No CHANGELOG entry detected for $CRATE_VERSION in: $CHANGELOG" >&2
else
echo "CHANGELOG contains entry for $CRATE_VERSION"
fi
else
echo "Note: No CHANGELOG file found; skipping."
fi
echo "OK: Version bump checks passed (basic)."
Length of output: 621
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# 1) Extract crate version without line numbers
CRATE_VERSION=$(rg -Po '^\s*version\s*=\s*"\K[0-9]+\.[0-9]+\.[0-9]+' Cargo.toml | head -n1)
echo "Crate version: $CRATE_VERSION"
# 2) If parseable_ui metadata exists, validate assets-url version
if rg -q '^\s*\[package\.metadata\.parseable_ui\]' Cargo.toml; then
URL_VER=$(rg -Po '^\s*assets-url\s*=\s*".*?/v\K[0-9]+\.[0-9]+\.[0-9]+' Cargo.toml | head -n1 || true)
echo "Assets URL version: ${URL_VER:-<not found>}"
if [[ -n "$URL_VER" ]] && [[ "$URL_VER" != "$CRATE_VERSION" ]]; then
echo "ERROR: assets-url version ($URL_VER) != crate version ($CRATE_VERSION)" >&2
exit 1
fi
fi
# 3) Verify CHANGELOG entry if present
CHANGELOG=$(fd -a -t f -i 'CHANGELOG*' || true)
if [[ -n "$CHANGELOG" ]]; then
if rg -q "^\s*##?\s*\[?$CRATE_VERSION\]?" $CHANGELOG; then
echo "CHANGELOG contains entry for $CRATE_VERSION"
else
echo "WARN: No CHANGELOG entry detected for $CRATE_VERSION in: $CHANGELOG" >&2
fi
else
echo "Note: No CHANGELOG file found; skipping."
fi
echo "OK: Version bump checks passed (basic)."
Length of output: 678
Version bump verified, but CHANGELOG entry & release artifacts needed
The assets-url
version (2.4.2) now matches the crate version (2.4.2), so metadata cohesion is good. However, there’s no CHANGELOG file detected—please add or update one—and ensure the Git tag and release notes are in place.
• Confirm a CHANGELOG (e.g. CHANGELOG.md) exists and includes a heading or entry for version 2.4.2
• Create and push the Git tag v2.4.2
• Draft or link release notes matching the changelog entry
🤖 Prompt for AI Agents
In Cargo.toml around line 3, the version was bumped to 2.4.2 but there is no
CHANGELOG entry or release artifacts; add or update a CHANGELOG (e.g.,
CHANGELOG.md) with a heading/entry for version 2.4.2 summarizing the changes,
commit that file, create and push the Git tag v2.4.2 (git tag v2.4.2 && git push
origin v2.4.2), and publish release notes on the repository (use the changelog
entry as the release description or link to it) so the tag, changelog, and
release notes are all present and consistent.
Summary by CodeRabbit