-
Notifications
You must be signed in to change notification settings - Fork 40
Add OpenPMD support #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add OpenPMD support #1050
Conversation
|
I asked GPT-5 to review this PR. Is this an accurate comment? |
|
On macOS with the Homebrew OpenMPI build and more than 1 MPI rank, ADIOS2 crashes due to a bug in OpenMPI (MPI shared memory windows are borked) and brings down Parthenon with it. I managed to work around this with |
|
I've added AMR support to my VisIt openPMD reader plugin: https://github.com/BenWibking/openpmd-visit-reader. Testing is welcome. |
Is the runtime config correct this way? |
yes, this is why the function body currently carries a |
Yes. I thought bp4 was still supported? Although I rebuilt OpenMPI with Spack on my Mac, and it works. So it's only an issue for the Homebrew-installed OpenMPI. |
Yes, correct. I just read up on this and bp4 might even have some advantages at large scale (though at the cost of a significant host memory footprint), see https://openpmd-api.readthedocs.io/en/latest/backends/adios2.html#heavy-i-o |
PR Summary
Leftover todos (potentially for future PRs):
Metadata::NonePR Checklist