Skip to content

Conversation

@lroberts36
Copy link
Collaborator

PR Summary

This PR allows for functions like FillDerived to optionally return a TaskStatus.

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@Yurlungur
Copy link
Collaborator

looks like tests are failing... is this ready for review? Also thanks for just going ahead and doing this!

@lroberts36
Copy link
Collaborator Author

looks like tests are failing... is this ready for review? Also thanks for just going ahead and doing this!

I think the failure was due to my linter not agreeing with the github linter, hopefully fixed now. Tests are passing on Darwin.

It is ready for review, but I think @swjones is going to test and see if it works for him before it goes in.

@pgrete pgrete changed the title Add optional TaskStatus for StateDescriptor callbacks WIP Add optional TaskStatus for StateDescriptor callbacks Aug 14, 2025
@pgrete
Copy link
Collaborator

pgrete commented Aug 14, 2025

@swjones could you please remove WIP again once you tested the functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants