Skip to content

Extra SparsePack indexers #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Extra SparsePack indexers #1308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
29decc7
Add a three index indexer for 1D vars
adamdempsey90 Aug 16, 2025
d34bead
Add a four index indexer for 2D vars
adamdempsey90 Aug 16, 2025
e29a54e
Merge branch 'develop' into dempsey/sparse_index
Yurlungur Aug 18, 2025
d37f835
Combine into variadic with forwarding
adamdempsey90 Aug 18, 2025
fe19d8b
changelog
adamdempsey90 Aug 18, 2025
8db0b10
Add extra integral requirement
adamdempsey90 Aug 18, 2025
b3c463c
Merge branch 'develop' into dempsey/sparse_index
pgrete Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Current develop

### Added (new features/APIs/variables/...)
- [[PR 1308]](https://github.com/parthenon-hpc-lab/parthenon/pull/1308) Add additional indexing options for (b, type, ...indices) meshdata fields. Helpful for lower dimensional Metadata::None fields.
- [[PR 1142]](https://github.com/parthenon-hpc-lab/parthenon/pull/1142) Unify par_dispatch, par_for_outer & par_for_inner overloads
- [[PR 1255]](https://github.com/parthenon-hpc-lab/parthenon/pull/1255) RK34 low storage 3rd order 4 stage SSP integrator with CFL <= 2 from Spiteri & Ruuth 2002, SIAM Journal on Numerical Analysis, 40(2):469–491
- [[PR 1283]](https://github.com/parthenon-hpc-lab/parthenon/pull/1283) Ability to automatically document ParameterInputs
Expand Down
10 changes: 10 additions & 0 deletions src/pack/sparse_pack.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,16 @@ class SparsePack : public SparsePackBase {
return pack_(0, b, vidx);
}

template <class TIn, typename... Args, REQUIRES(sizeof...(Args) > 0),
REQUIRES(all_implement<integral(Args...)>::value),
REQUIRES(IncludesType<TIn, Ts...>::value)>
KOKKOS_INLINE_FUNCTION auto &operator()(const int b, const TIn &t,
Args &&...args) const {
PARTHENON_DEBUG_REQUIRE(!flat_, "Accessor cannot be used for flat packs");
const int vidx = GetLowerBound(b, t) + t.idx;
return pack_(0, b, vidx)(std::forward<Args>(args)...);
}

KOKKOS_INLINE_FUNCTION
Real &operator()(const int b, const int idx, const int k, const int j,
const int i) const {
Expand Down
Loading