Skip to content

Conversation

@peter279k
Copy link

@peter279k peter279k commented Oct 19, 2018

What?

  • Test enhancement.
  • Since the php-5.6 version supports until 2018-12-31, let this package require php-7.0+ version at least.
  • Upgrade the PHPUnit versions to support php-7.0+ version.
  • Update the composer.lock file.
  • Add the white filter list in phpunit.xml for someone want to check the current code coverage report.

Checklist

  • Added unit test for added/fixed code
  • Updated the documentation
  • Scrutinizer code coverage is 100%
  • Scrutinizer code quality is as high as possible

@rick-nu
Copy link
Contributor

rick-nu commented Oct 19, 2018

Hey @peter279k, thanks a lot for your PR! I'll be sure to merge this soon and bump the major version for a new release. You're absolutely right, it's time to drop PHP 5 support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants