perf: partially unroll sha3 Chi #126
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the size, but only a bit (unlike a full unroll, ref: #88 (comment)), and still keeps readability / auditability
The main optimization here is that you don't need a full B copy, only a few indices that intersect
This gives ~1.4x speedup in Node.js
Before (Node.js 22):
After (Node.js 22):
And ~1.2-1.3x speedup in Hermes
Before (Hermes on M3):
After (Hermes on M3):