Add overload to Bech32.decode to handle arbitrary string input #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, it was not possible to decode an arbitrary string from user input without preprocessing it for the library. The reason is we don't always have the strong type
${Prefix}1${string}or even${string}1${string}available. A cast fromstringto${string}1${string}is unsafe without an extra runtime check.Even the tests file in this project mark the use of
stringinputs as type errors:But it turns out
genBech32has the overload and runtime checks already. It just needs to be exposed to the user.Closes #43