Skip to content

fix(ui): select dropdown obscured by header in landscape mode #14160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): select dropdown obscured by header in landscape mode #14160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui/src/elements/ReactSelect/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
}

.rs__menu {
z-index: 4;
z-index: var(--z-select-menu);
border-radius: 0;
@include shadow-lg;
background: var(--theme-input-bg);
Expand Down
2 changes: 2 additions & 0 deletions packages/ui/src/fields/Select/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
@layer payload-default {
.field-type.select {
position: relative;
// Fixes a bug where the Select field's dropdown menu would be hidden behind the AppHeader in landscape mobile mode
z-index: 1;
}

html[data-theme='light'] {
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/scss/app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
--z-popup: 10;
--z-nav: 20;
--z-modal: 30;
--z-select-menu: 35;
--z-status: 40;

--accessibility-outline: 2px solid var(--theme-text);
Expand Down