Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ venv
/dist/*
/AUTHORS
/ChangeLog
/.eggs
/.eggs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a trailing line break.

6 changes: 5 additions & 1 deletion airtable/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import warnings

import requests
from requests.packages.urllib3.util import retry
import six

API_URL = 'https://api.airtable.com/v%s/'
Expand Down Expand Up @@ -94,7 +95,10 @@ def __init__(self, base_id, api_key, dict_class=OrderedDict):
def __request(self, method, url, params=None, payload=None):
if method in ['POST', 'PUT', 'PATCH']:
self.headers.update({'Content-type': 'application/json'})
response = requests.request(
retries = retry.Retry(total=10, backoff_factor=1, status_forcelist=[429, 500, 502, 503, 504])
session = requests.Session()
session.mount('https://', requests.adapters.HTTPAdapter(max_retries=retries))
response = session.request(
method,
posixpath.join(self.base_url, url),
params=params,
Expand Down
1 change: 1 addition & 0 deletions requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
pylint
flake8
requests-mock
httpretty
41 changes: 40 additions & 1 deletion test_airtable.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
from typing import Any, Dict
import unittest
import json

import requests_mock

import httpretty
import airtable
import re

FAKE_TABLE_NAME = 'TableName'
FAKE_BASE_ID = 'app12345'
Expand Down Expand Up @@ -33,6 +35,43 @@ def test_build_headers(self):
self.assertEqual(self.airtable.headers['Authorization'],
'Bearer fake_api_key')

@httpretty.activate
def test_retries(self):
httpretty.register_uri(
httpretty.GET,
re.compile(r'https://.*'),
responses=[
httpretty.Response(
body='{}',
status=429,
),
httpretty.Response(
body='{}',
status=500,
),
httpretty.Response(
body=json.dumps({
'records': [
{
'id': 'reccA6yaHKzw5Zlp0',
'fields': {
'Name': 'John',
'Number': '(987) 654-3210'
}
}
],
'offset': 'reccg3Kke0QvTDW0H'
}),
status=200,
),
]
)

res = self.get()
self.assertEqual(3, len(httpretty.latest_requests()))
self.assertEqual(len(res['records']), 1)
self.assertEqual(res['offset'], 'reccg3Kke0QvTDW0H')

@requests_mock.mock()
def test_get_all(self, mock_requests):
mock_requests.get('https://api.airtable.com/v0/app12345/TableName', json={
Expand Down