Skip to content

Rewrite the video demo #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2019
Merged

Rewrite the video demo #9

merged 3 commits into from
Jun 14, 2019

Conversation

fnevgeny
Copy link
Member

I'm not certain whether we are allowed to distribute the Apollo movie. Perhaps should use a URL link instead of the file. This would also eliminate the need for the zip packaging and greatly reduce the size - a single PDF would be enough.

@fnevgeny fnevgeny requested a review from AndreasBilke June 12, 2019 23:30
@andybarry
Copy link
Contributor

The Apollo movie is in the public domain. That's why I chose it :)

https://commons.m.wikimedia.org/wiki/File:Ap17-ascent.ogv

When I made the demo, I wanted it to be totally self-contained to reduce the number of confounding factors to deal with when figuring out why a system didn't work, so I think that distributing the movie is worthwhile.

But, I've been gone for years, so all good whatever you guys want to do.

Copy link
Member

@AndreasBilke AndreasBilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing $(RM) is also in demo/Makefile.

I would propose in general to stop shipping Makefiles for latex code (they are always a mess) and use latexmk on your own instead.

If you prefer the Makefile then make clean should work :-)

all : $(PDFDOCS)

clean :
$(RM) $(PDFDOCS) *.aux *.log *.toc *.nav *.out *.snm *.vrb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(RM) variable is not defined. So a make clean raises an error for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreasBilke AndreasBilke merged commit cd4f0c0 into master Jun 14, 2019
@fnevgeny fnevgeny deleted the video-example branch June 14, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants