Allow compiling with markdown3 #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wentasah
force-pushed
the
markdown3
branch
2 times, most recently
from
07b1c96 to
08e66b9
Compare
|
Sorry for the force-push spam. I was fixing CI failures. Let me know whether minimum cmake version bump is OK. If not, I'll try to come up with a more compatible solution. |
This was referenced Apr 17, 2024
fnevgeny
requested changes
Oct 18, 2024
CMakeLists.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.5) | |||
| cmake_minimum_required(VERSION 3.7) | |||
There was a problem hiding this comment.
Please update README.rst accordingly.
|
README updated and rebased to master. |
Currently compilation fails with:
/build/src/classes/renderer/markdown.c:191:20: error: variable or field 'flags' declared void
According to comment [1], markdown3 introduces backward
incompatibility with respect to document flags.
This commit adds conditionally compiled code that allows building
pdfpc with both markdown versions 2 and 3.
The used cmake operator VERSION_GREATER_EQUAL requires cmake 3.7 so we
bump minimal cmake version requirement.
Fixes pdfpc#682
[1]: pdfpc#682 (comment)
fnevgeny
approved these changes
Oct 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently compilation fails with:
According to comment 1, markdown3 introduces backward incompatibility with respect to document flags.
This commit adds conditionally compiled code that allows building pdfpc with both markdown versions 2 and 3.
Fixes #682