Skip to content
This repository was archived by the owner on Sep 21, 2021. It is now read-only.

add self scoped, singleton and transient support #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add self scoped, singleton and transient support #2

wants to merge 2 commits into from

Conversation

sefacan
Copy link

@sefacan sefacan commented Sep 24, 2020

We have self registration support now.

@peacecwz
Copy link
Collaborator

@sefacan Thanks for your contribution 🎉🎉 I reviewed your commit(s), and I have someone questions

  1. Why did you add "self" prefix to attributes?
  2. I see to change "Type" declaration to "var." I think it's killing readable code. Because I would like to see "assembly.GetTypes()" return type. If you change with "var" keyword. It's not readable.

@peacecwz peacecwz added the neeed-works Need Works label Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@furkandeveloper furkandeveloper furkandeveloper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

neeed-works Need Works

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sefacan @peacecwz @furkandeveloper