feat(sublet): add FE apis and interfaces #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 90.41% 90.37% -0.04%
==========================================
Files 62 62
Lines 2681 2681
==========================================
- Hits 2424 2423 -1
- Misses 257 258 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vcai122
reviewed
Oct 14, 2024
frontend/api/sublet/offersApi.ts
Outdated
| export const createOffer = async ( | ||
| subletId: string, | ||
| data: CreateOfferRequest | ||
| ): Promise<void> => { |
Contributor
There was a problem hiding this comment.
Probably the response shouldn't be void? We should return the response so we can check it and maybe display an error or sucess message based off of it.
In general is it nescecary to throw after each call (i have no preference here but just wondering). Why not just return the response and have the caller inspect it? It seems natural that for most responses we might want to handle the happy case and the bad case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add frontend API methods and interfaces for subletting.