Skip to content

PBM-1593 Use RetryReader when reading from Azure #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

PBM-1593 Use RetryReader when reading from Azure #1177

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3639bee
Use RetryReader when reading from Azure
DanielOliverRJ Aug 13, 2025
d2a5ed6
Accept suggestion from Copilot
DanielOliverRJ Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pbm/storage/azure/azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,14 @@ func (b *Blob) SourceReader(name string) (io.ReadCloser, error) {
return nil, errors.Wrap(err, "download object")
}

return o.Body, nil
rr := o.NewRetryReader(context.TODO(), &azblob.RetryReaderOptions{
EarlyCloseAsError: true,
OnFailedRead: func(failureCount int32, lastError error, rnge azblob.HTTPRange, willRetry bool) {
// failureCount is reset on each call to Read(), so repeats of "attempt 1" are expected
b.log.Debug("Read from Azure failed (attempt %d): %v, retrying: %v\n", failureCount, lastError, willRetry)
},
})
return rr, nil
}

func (b *Blob) Delete(name string) error {
Expand Down
Loading