-
Notifications
You must be signed in to change notification settings - Fork 31
Refactor websockets dependencies: move the optional dependency to extras and unite imports #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor websockets dependencies: move the optional dependency to extras and unite imports #51
Conversation
…ras and unite imports
|
@orweis @danyi1212 Do you have time to take a look at it and review the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mberdyshev I think the new build workflow is starting now with python 3.9 and on, try to pull from the last commit and run again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mberdyshev thanks for this, I added my comments, and am happy to help with anything needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mberdyshev This looks good to me know. Thank you!
Support latest versions for tests.
@orweis, hello! Do you have time now for the code review? |
I believe @iwphonedo is on the case. |
@iwphonedo has already approved this PR. However, GitHub writes that merging is blocked because "At least 1 approving review is required by reviewers with write access". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved - @mberdyshev once you're ready you can merge / ask me to merge.
Thank you for your contribution.
@gemanor @danielbass37 - let's offer the man some Permit Swag as thank you
@orweis I have no available option to merge this PR, so you are welcome to do it. |
Congratulations - it's merged 😇 |
Thank you! Is it possible to make a new PyPI release? |
|
Great! Thank you a lot! |
No description provided.