Skip to content

Conversation

mberdyshev
Copy link
Contributor

No description provided.

@mberdyshev
Copy link
Contributor Author

mberdyshev commented Dec 6, 2024

websockets dropped support of Python 3.8 and lower. Should the library drop it too? It has reached the EOL.
UPD: Dropped them.

@mberdyshev
Copy link
Contributor Author

mberdyshev commented Dec 12, 2024

@orweis @danyi1212 Do you have time to take a look at it and review the code?

Copy link

@izzywdev izzywdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mberdyshev I think the new build workflow is starting now with python 3.9 and on, try to pull from the last commit and run again.

Copy link

@izzywdev izzywdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mberdyshev thanks for this, I added my comments, and am happy to help with anything needed.

@mberdyshev mberdyshev requested a review from izzywdev December 26, 2024 06:49
Copy link

@izzywdev izzywdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mberdyshev This looks good to me know. Thank you!

Support latest versions for tests.
@mberdyshev
Copy link
Contributor Author

@orweis, hello! Do you have time now for the code review?

@orweis
Copy link
Contributor

orweis commented Jan 10, 2025

I believe @iwphonedo is on the case.
Izzy, let us know if you can get to this soon.

@mberdyshev
Copy link
Contributor Author

@iwphonedo has already approved this PR. However, GitHub writes that merging is blocked because "At least 1 approving review is required by reviewers with write access".

Copy link
Contributor

@orweis orweis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - @mberdyshev once you're ready you can merge / ask me to merge.
Thank you for your contribution.

@gemanor @danielbass37 - let's offer the man some Permit Swag as thank you

@mberdyshev
Copy link
Contributor Author

@orweis I have no available option to merge this PR, so you are welcome to do it.

@orweis orweis merged commit 919d791 into permitio:master Jan 13, 2025
7 checks passed
@orweis
Copy link
Contributor

orweis commented Jan 13, 2025

@orweis I have no available option to merge this PR, so you are welcome to do it.

Congratulations - it's merged 😇

@mberdyshev
Copy link
Contributor Author

mberdyshev commented Jan 13, 2025

Thank you! Is it possible to make a new PyPI release?

@orweis
Copy link
Contributor

orweis commented Jan 13, 2025

Thank you! Is it possible to make a new PyPI release?

https://pypi.org/project/fastapi-websocket-rpc/0.1.28/ ;-)

@mberdyshev
Copy link
Contributor Author

Great! Thank you a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants