Add requirements.txt to the source distribution and remove the unused parameter from setup.cfg
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, it has only one obsolent attribute `description-file`, which should be `long_description` now. Secondly, `long_description` is already present in `setup.py` file, so the removed file does add nothing useful to the setup configuration. Find additional info here: https://stackoverflow.com/q/60084128/6609485 pypa/setuptools#4910 https://github.com/pypa/setuptools/blob/v79.0.0/docs/userguide/declarative_config.rst#compatibility-with-other-tools
`LICENSE` and `README.md` are by default included to the distrubution, so there is no need to include them explicitly. Docs: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html Fixes #29
orweis
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the commit descriptions for the reasoning behind the changes.
Fixes #29.