Skip to content

Fix: Fix GitHub Issue #3742: Private GH repo: Cannot read properties of undefined (reading 'number') **I... #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −0
Open

Fix: Fix GitHub Issue #3742: Private GH repo: Cannot read properties of undefined (reading 'number') **I... #4215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,6 +1377,13 @@ class GitHubHelper {
// Update the pull request that exists for this branch and base
core.info(`Fetching existing pull request`);
const { data: pulls } = yield this.octokit.rest.pulls.list(Object.assign(Object.assign({}, this.parseRepository(baseRepository)), { state: 'open', head: headBranch, base: inputs.base }));
if (pulls.length === 0) {
throw new Error(`No open pull request found for head branch '${headBranch}' and base branch '${inputs.base}'. ` +
`This may occur if: (1) the pull request was already merged or closed, ` +
`(2) the token lacks sufficient permissions to list pull requests in this repository, or ` +
`(3) there is an issue with the branch reference format. ` +
`Please verify the pull request exists and the token has 'pull-requests: read' permission.`);
}
core.info(`Attempting update of pull request`);
const { data: pull } = yield this.octokit.rest.pulls.update(Object.assign(Object.assign({}, this.parseRepository(baseRepository)), { pull_number: pulls[0].number, title: inputs.title, body: inputs.body }));
core.info(`Updated pull request #${pull.number} (${headBranch} => ${inputs.base})`);
Expand Down
11 changes: 11 additions & 0 deletions src/github-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,17 @@ export class GitHubHelper {
head: headBranch,
base: inputs.base
})

if (pulls.length === 0) {
throw new Error(
`No open pull request found for head branch '${headBranch}' and base branch '${inputs.base}'. ` +
`This may occur if: (1) the pull request was already merged or closed, ` +
`(2) the token lacks sufficient permissions to list pull requests in this repository, or ` +
`(3) there is an issue with the branch reference format. ` +
`Please verify the pull request exists and the token has 'pull-requests: read' permission.`
)
}

core.info(`Attempting update of pull request`)
const {data: pull} = await this.octokit.rest.pulls.update({
...this.parseRepository(baseRepository),
Expand Down