executable comment addition to the method findAnySubstring #18354
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on startingAt: start in String class
jordanmontt
approved these changes
Jun 29, 2025
|
The comment is not correct The following test is failing. |
Ducasse
reviewed
Jun 29, 2025
| { #category : 'finding/searching' } | ||
| String >> findAnySubstring: aCollection startingAt: start [ | ||
| "Answer the index where an element of aCollection begins. If none are found, answer size + 1. aCollection is an Array of Strings or Characters." | ||
| "'abcdef' findAnySubstring: 'cde' startingAt: 1 >>> 3" |
There was a problem hiding this comment.
Please put parentheses because >>> is a binary message so it is executed prior to findAny..:
Ducasse
added
the
Status: Need more work
jordanmontt
requested review from
jordanmontt
and removed request for
jordanmontt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #18334
findAnySubstring: aCollection startingAt: start
Part 2 :))