use entity.MarshalJSON instead of json.Marshal. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarelit
suggested changes
Jul 12, 2022
Member
zarelit
left a comment
zarelit
left a comment
There was a problem hiding this comment.
Changes okay, error linting okay, there's one thing to change in the last changed line (see comment)
Comment on lines
816
to
825
| if resp.StatusCode == http.StatusCreated { | ||
| return resp.Header.Get("Location"), false, nil | ||
| } else if resp.StatusCode == http.StatusNoContent { | ||
| } | ||
|
|
||
| if resp.StatusCode == http.StatusNoContent { | ||
| return resp.Header.Get("Location"), true, nil | ||
| } else { | ||
| bodyBytes, _ := ioutil.ReadAll(resp.Body) | ||
| return "", false, fmt.Errorf("Unexpected status code: '%d'\nResponse body: %s", resp.StatusCode, string(bodyBytes)) | ||
| } |
Member
There was a problem hiding this comment.
This is not an if statement used to return early because of error, and the most "special" case is the last one. So it's probably better to do one of the following:
- make this whole block a switch/case statement
- or remove both the
elsebranches including the one beforebodyBytes, _ := - leave the if / else if / else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.