Skip to content

Fix properties_info_table for abstract properties #19140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix properties_info_table for abstract properties #19140

wants to merge 3 commits into from
+43 −2

Conversation

iluuu1994
Copy link
Member

Fixes GH-19053

@iluuu1994 iluuu1994 requested a review from bwoebi July 15, 2025 18:40
@iluuu1994 iluuu1994 requested a review from dstogov as a code owner July 15, 2025 18:40
nielsdos
nielsdos reviewed Jul 15, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jul 21, 2025
View reviewed changes
bwoebi
bwoebi approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks :-)

@iluuu1994 @bwoebi
Embed initial stop cond into while cond (@bwoebi)
ca3813a 
Co-authored-by: Bob Weinand <bobwei9@hotmail.com>
@iluuu1994 iluuu1994 closed this in c8cc233 Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos left review comments

@bwoebi bwoebi bwoebi approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iluuu1994 @bwoebi @nielsdos