PDO: Migrate maxlen of pdo_column_data from size_t to zend_long #19144
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is returned in PDOStatement::getColumnMeta as
len
documented as "The length of this column. Normally -1 for types other than floating point decimals."Also, It was as
FIXME
already.PQfsize
: returns the space allocated for this column in a database row, in other words the size of the server's internal representation of the data type. (Accordingly, it is not really very useful to clients.) A negative value indicates the data type is variable-length.dbcollen
: The maximum length, in bytes, of the data for the particular column. If the column number is not in range, dbcollen returns -1.XSQLVAR.sqllen
->ISC_SHORT
->signed short
: length of data areaMYSQL_FIELD.length
MYSQLND_FIELD.length
->zend_ulong
: Width of column (create length)unsigned long length
: Width of column (create length)I noticed this during my work of 64bit integers on 32bit arch where it would was failing: https://github.com/php/php-src/actions/runs/16311803646/job/46068812948#step:9:2782