ext/intl: using a bit more modern c++ memory management features. #19163
+20
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not always possible (e.g. PHP objects) but when scoped we can manage here to simplify memory managament starting with IntlDateFormat.
nielsdos
reviewed
Jul 17, 2025
| @@ -70,10 +70,10 @@ U_CFUNC PHP_FUNCTION(datefmt_format_object) | |||
| size_t locale_len; | |||
| bool pattern = false; | |||
| UDate date; | |||
| TimeZone *timeZone = NULL; | |||
| std::unique_ptr<TimeZone> timeZone = NULL; | |||
There was a problem hiding this comment.
I believe it's not necessary to value-initialize these unique_ptrs.
| "datefmt_format_object") == FAILURE) { | ||
| RETURN_FALSE; | ||
| } | ||
| cal = new GregorianCalendar(Locale::createFromName(locale_str), status); | ||
| timeZone = std::unique_ptr<TimeZone>(tz); | ||
| cal = std::unique_ptr<Calendar>(new GregorianCalendar(Locale::createFromName(locale_str), status)); |
There was a problem hiding this comment.
Can't you use make_unique here instead of unique_ptr+new ?
There was a problem hiding this comment.
I wish but isn't it C++14 minimum ?
There was a problem hiding this comment.
Ah right, and it's the ICU version that decides between C++11/C++17... Nvm then ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not always possible (e.g. PHP objects) but when scoped we can manage here to simplify memory managament starting with IntlDateFormat.