Fix PDOStatement getIterator stub type #3974
Open
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
suggested changes
Apr 30, 2025
|
@staabm thanks for the |
|
This pull request has been marked as ready for review. |
staabm
approved these changes
May 1, 2025
|
Please rebase this to fix conflicts, thanks. |
mbolli
force-pushed
the
fix-pdostatement-getiterator
branch
from
e705114 to
c0efe59
Compare
|
@ondrejmirtes rebase done. not sure if the failing tests matter. |
staabm
reviewed
Jul 29, 2025
|
You still have to fix the lint failure |
Comment on lines
+232
to
+233
|
|
||
| // note: files in ./nsrt will be automatically picked up |
There was a problem hiding this comment.
You don't have to add this.
This is a consequence of the first line
foreach (self::findTestDataFilesFromDirectory(__DIR__ . '/nsrt') as $testFile) {
yield $testFile;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#8886