Validate checkedExceptionClasses config #3987
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janedbal
commented
May 12, 2025
| @@ -27,6 +28,16 @@ public function __construct( | |||
| private array $checkedExceptionClasses, | |||
| ) | |||
| { | |||
| foreach ($this->checkedExceptionClasses as $checkedExceptionClass) { | |||
| if (!$this->reflectionProvider->hasClass($checkedExceptionClass)) { | |||
| throw new ShouldNotHappenException('Class ' . $checkedExceptionClass . ' used in \'checkedExceptionClasses\' does not exist.'); | |||
There was a problem hiding this comment.
Not sure if this is the preferred way of config validation.
| if (!$this->reflectionProvider->hasClass($uncheckedExceptionClass)) { | ||
| throw new ShouldNotHappenException('Class ' . $uncheckedExceptionClass . ' used in \'uncheckedExceptionClasses\' does not exist.'); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you want that behind featureFlag / bleedingEdge? I think this will be pretty rare.
ondrejmirtes
requested changes
Jul 17, 2025
| @@ -27,6 +28,16 @@ public function __construct( | |||
| private array $checkedExceptionClasses, | |||
| ) | |||
| { | |||
| foreach ($this->checkedExceptionClasses as $checkedExceptionClass) { | |||
| if (!$this->reflectionProvider->hasClass($checkedExceptionClass)) { | |||
| throw new ShouldNotHappenException('Class ' . $checkedExceptionClass . ' used in \'checkedExceptionClasses\' does not exist.'); | |||
There was a problem hiding this comment.
This is a BC break. Also I'd prefer it if happened in ContainerFactory. There's already validateParameters method.
There was a problem hiding this comment.
So yeah, please put this only in bleeding edge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.