fix: False match.unhandled on array with multiple booleans #4030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you ignore the error for every remaining array, I assume you won't have an error if you miss an "array" case Like
Can you add tests to prove it works ? |
ondrejmirtes
requested changes
Jul 17, 2025
| @@ -132,6 +132,7 @@ public function processNode(Node $node, Scope $scope): array | |||
| !$remainingType instanceof NeverType | |||
| && !$this->isUnhandledMatchErrorCaught($node) | |||
| && !$this->hasUnhandledMatchErrorThrowsTag($scope) | |||
| && !$remainingType->isArray()->yes() | |||
There was a problem hiding this comment.
This is a bad bugfix. This shuts up the rule for all arrays.
There was a problem hiding this comment.
I'm trying to find the right way to fix this. Thanks for the review! @ondrejmirtes @VincentLanglet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix phpstan/phpstan#13029