Resolve substr based on configured PHP version #4061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
substr
branch
3 times, most recently
from
364fbed to
6b4f063
Compare
VincentLanglet
commented
Jun 13, 2025
|
This pull request has been marked as ready for review. |
staabm
reviewed
Jun 13, 2025
|
btw: since phpunit got upgraded on the PHPStan 2.x branch, we need to be careful to send PRs to PHPStan 1.12.x only when easy mergabe into 2.x (attributes got added etc) |
Only change is this attribute I dunno if it will even create a conflict but if ondrej ask, I can target 2.1.x instead :) |
|
I'd prefer this one only for 2.1.x :) Thanks. |
|
Rebased on 2.1.x @ondrejmirtes |
ondrejmirtes
requested changes
Jul 17, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13129