Don't attempt to render blank URLs #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @akalra, thank you very much for this PR! I'll go into more review once I have some time, but I'll add some comments to the code in the meantime. |
|
|
||
| def blank? | ||
| data.blank? | ||
| end |
There was a problem hiding this comment.
The Travis build is currently failing because of Rubocop. Can we delegate this so Rubocop is happy?
http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Rails/Delegate
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi --
Relatively minor pull request, but our admin console was littered with broken image tags for places where the image hadn't been populated yet.
This is a quick and dirty version. Ideally, I'd like to let the user decide what the 'blank field' experience is (perhaps by rendering a user-specified partial), but providing a path to the partial as an option didn't seem right. Wanted to run this past you before I spent too much more time on it.
Thanks!
Ankur