Skip to content

feat/slate-editor-updates #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 62 commits into
base: develop
Choose a base branch
from
Draft

feat/slate-editor-updates #1066

wants to merge 62 commits into from

Conversation

lakatosandrei
Copy link
Contributor

No description provided.

@andreeapescar
build: setup to build next versions, prevented pslb built as it is no…
ca75c57 
…t working on this branch and a fix: reverted incorrectly mered conflicts to mark-label.test.js
@andreeapescar andreeapescar force-pushed the feat/slate-editor-updates branch from a89a4bb to ca75c57 Compare January 11, 2024 11:38
circleci and others added 20 commits January 11, 2024 11:40
[ci skip] update changelog.json
8e0c622
@andreeapescar
Merge pull request #1070 from pie-framework/develop
9ab95c9 
Merge
@lakatosandrei
feat: initial work for ENTER KEY for lists [PD-3301]
7977cf1
@lakatosandrei
feat: implemented functionality for enter and backspacae [PD-3301]
3fef275
@lakatosandrei
Merge branch 'feat/slate-editor-updates' of https://github.com/pie-fr…
34788f5 
…amework/pie-lib into fix/PD-3301
@andreeapescar
chore: prevent develop builds as no one uses pie-lib next versions, a…
0bacaf9 
…nd we'll use them for slate testing
@andreeapescar
Merge pull request #1098 from pie-framework/fix/PD-3301
c0e7862 
fix: implemented list handling for slate [PD-3301]
@andreeapescar
Merge with develop
87589e2
@andreeapescar
Merge pull request #1106 from pie-framework/feat/slate-editor-updates…
217d1f3 
…-12-feb

Merge with develop
@lakatosandrei
fix: handled first child in case that is not an actual block [PD-3303]
0d0ec39
@lakatosandrei
Merge branch 'develop' of https://github.com/pie-framework/pie-lib in…
851fdc0 
…to feat/slate-editor-updates
@lakatosandrei
fix: made sure enter and shift enter work properly [PD-3531]
2e2fac0
@andreeapescar
Merge pull request #1175 from pie-framework/fix/PD-3531
4a62039 
fix: made sure enter and shift enter work properly [PD-3531]
@lakatosandrei
Merge branch 'develop' of https://github.com/pie-framework/pie-lib in…
8b13b7e 
…to feat/slate-editor-updates
@andreeapescar
fix: serialization is not used in slate-editor-updates, and tests wer…
490d7f4 
…e failing
@lakatosandrei
fix: added UNDO button [PD-3494]
2190f23
@lakatosandrei
fix: fixed some list wrapping and unwrapping issues PD-3493
fee67f4
@andreeapescar
Merge pull request #1204 from pie-framework/fix/PD-3493
96a0139 
fix: fixed some list wrapping and unwrapping issues PD-3493
@andreeapescar
Merge pull request #1201 from pie-framework/fix/PD-3494
6e903b5 
fix: added UNDO button [PD-3494]
@andreeapescar
chore: pull origin develop
3be43db
lakatosandrei and others added 28 commits April 27, 2024 14:05
@lakatosandrei
fix: fixed media insert for editor [PD-3702]
10babd6
@lakatosandrei
fix: made sure disableUnderline works properly [PD-3700]
fc1ebf6
@lakatosandrei
fix: multi trait rubric editor height issues, undo button [PD-3705]
74246bf
@andreeapescar
Merge pull request #1226 from pie-framework/fix/PD-1886-fixes
0ce5240 
Fix/pd 1886 fixes
@andreeapescar
Merge branch 'develop' of github.com:pie-framework/pie-lib into feat/…
415b007 
…slate-editor-updates
@andreeapescar
fix: use math-rendering-accessible
312f123
@andreeapescar
fix: pslb build PD-3379
6084f2e
@lakatosandrei
fix: used inherit in order for the editor to not take the whole avail…
a0d6024 
…able space [PD-3705], [PD-3716]
@lakatosandrei
fix: deleting response area by using delete button is not crashing th…
9099503 
…e editor [PD-3720]
@andreeapescar
fix: pslb build PD-3379
d7898eb
@andreeapescar
fix: update pslb with beta, which will release next versions PD-3379
7f64375
@andreeapescar
Merge pull request #1228 from pie-framework/fix/pslb
b0690b4 
fix: pslb build PD-3379
@andreeapescar
fix: testing builds
e01cd5b
@lakatosandrei
fix: fixed undo, issue when pasting images, markup element choices PD…
8e0234e 
…-3686, PD-3710, PD-3717, PD-3721
@lakatosandrei
fix: made sure empty editor is not outputing a paragraph [PD-3715]
a506640
@lakatosandrei
fix: added onKeyDown in order to not let user to delete the table fro…
82ece7a 
…m inside of it using backspace [PD-3722]
@andreeapescar
feat: migrate custom plugins PD-3625
e529560
@lakatosandrei
feat: added line breaks for paragraphs in the editor [PD-3737]
d80f790
@lakatosandrei
fix: using div by default if an empty prompt is provided [PD-3715]
c3903f5
@lakatosandrei
fix: fixed white spaces inside the table [PD-3699]
5251cf8
@andreeapescar
Merge pull request #1240 from pie-framework/feat/PD-3625
55cf0cd 
feat: migrate custom plugins PD-3625
@lakatosandrei
fix: made sure table can be added before an image [PD-3746]
3013b97
@andreeapescar
fix: placeholders are not rendering PD-3749
1b9ae00
@andreeapescar
Merge pull request #1250 from pie-framework/fix/PD-3749
5af0852 
fix: placeholders are not rendering PD-3749
@andreeapescar
fix: editors are not being properly displayed for graphing labels PD-…
8ddc994 
…3759
@andreeapescar
fix: editors are not being properly displayed for graphing labels cle…
76d7763 
…an-up PD-3759
@lakatosandrei
Merge pull request #1251 from pie-framework/fix/PD-3759
382cb7a 
Fix/pd 3759
@lakatosandrei
fix: weird behaviour inside list and with images [PD-3747]
cd9f2bf
@andreeapescar andreeapescar marked this pull request as draft September 16, 2024 07:25
@andreeapescar
Copy link
Contributor

We abandoned updating slate editor as it was causing multiple other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreeapescar andreeapescar Awaiting requested review from andreeapescar

@PatriciaRomaniuc PatriciaRomaniuc Awaiting requested review from PatriciaRomaniuc

@andreeimiron andreeimiron Awaiting requested review from andreeimiron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lakatosandrei @andreeapescar