refactor(rubric): BREAKING CHANGE Remove unnecessary code #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to rename the commit to: "refactor: removed part of rubric code PD-3672 BREAKING CHANGE: Remove unnecessary code regarding rubric after moving it to pie-elements" |
dianagociu
force-pushed
the
refactor/PD-3672
branch
from
9b7509e to
8f5bc23
Compare
BREAKING CHANGE: Remove unnecessary code regarding rubric after moving it to pie-elements
dianagociu
force-pushed
the
refactor/PD-3672
branch
from
8f5bc23 to
5efea82
Compare
|
Just a comment here. This PR is opened since a long time and I haven't merged it because I think we removed too much. We might need to re-check it before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://illuminate.atlassian.net/browse/PD-3672