Exports SogsMeta type
#7723
Open
Exports SogsMeta type
#7723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpal81xd
requested changes
May 28, 2025
| */ | ||
|
|
||
| /** | ||
| * @typedef {Object} SogsTexture |
There was a problem hiding this comment.
Suggested change
| * @typedef {Object} SogsTexture | |
| * @typedef {object} SogsTexture |
| */ | ||
|
|
||
| /** | ||
| * @typedef {Object} SogsMeta |
There was a problem hiding this comment.
Suggested change
| * @typedef {Object} SogsMeta | |
| * @typedef {object} SogsMeta |
|
I think it's premature to expose this as pubic API. I think we need to give @slimbuck and @mvaligursky a bit more time for finalize the general GSplat interface. |
|
@marklundin Presumably this can be closed now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports a
SogsMetatype for Sogs meta data. This is a handy type that's useful for engine consumers (@playcanvas/react). Also generates associated docs.prop descriptions tbd