#377 - Automatically support test and expect aliases with variable references
#386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskelton
reviewed
Aug 17, 2025
There was a problem hiding this comment.
This test isn't really helpful, let's remove it.
| * For example, for `import { test as foo } from '@playwright/test'`, | ||
| * `getImportedAliases(context, 'test')` will return `['foo']`. | ||
| */ | ||
| export function getImportedAliases( |
There was a problem hiding this comment.
This doesn't tell the full story. What if for example you want to do this:
const custom = test.extend()
which is very common in Playwright. With this method, that wouldn't be caught.
We shouldn't just use AST parsing, we should find any test import, and then track all of it's references including .extend assignments, and then those are the valid aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of changes in this PR:
getImportedAliasesto thesrc/utils/ast.tsthat gets and resolves importedAliases. The function is heavy guarded against various runtime erros.resolveToPlaywrightFnto usegetImportedAliases.testandexpectaliases.src/utils/ast.ts.