Andrew/mathjax #393
Andrew/mathjax #393
Conversation
src/py/kaleido/vendor/index.html
Outdated
| <!-- | ||
| THIS FILE IS AN EXAMPLE, IT IS GENERATED AUTOMATICALLY AT RUNTIME | ||
| TO ENSURE FULLY UPDATED RESOURCES | ||
| --> |
There was a problem hiding this comment.
this doesn't make sense to me, what is the function of this file? Should it be checked into git at all?
There was a problem hiding this comment.
Legacy code that I've been using throughout this process and as documentation. It's definitely on its way out, I can axe it.
src/py/kaleido/vendor/index.html
Outdated
| </script> | ||
|
|
||
| <!-- Only your one tweak; preset handles TeX+AMS+SVG --> |
| <script src="\S[^\n]*/kaleido_scopes\.js"></script> | ||
| </head> | ||
| <body style="{margin: 0; padding: 0;}"><img id="kaleido-image"></img></body> | ||
| <body style="{margin: 0; padding: 0;}"><img id="kaleido\-image" /></body> |
There was a problem hiding this comment.
why the backslash in the id?
There was a problem hiding this comment.
I'm not super happy with how convoluted these tests are and I'm thinking about doing them line by line.
In certain instances, '-' is a reserved character in regex. In this particular instance, it doesn't need to be, but can be, escaped.
There's a run on testing today, this whole strategy might change in another PR.
|
@ayjayt Just to make sure I understand -- the root cause of the two linked issues is the fact that the Mathjax script was being loaded after the Plotly script? |
a) we bring mathjax into line with plotly.py which solves one issues. It seems to me mathjax should be loaded if I'm going to tell plotly that it is loaded |
This updates mathjax and script ordering to be more in line with expectations