Skip to content

Andrew/test arm #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/publish_testpypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,27 @@ jobs:
strategy:
max-parallel: 2
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-latest, macos-latest, ubuntu-24.04-arm]
python_v: ['3.8', '3.9', '3.10', '']
# chrome_v: ['-1']
name: Build and Test
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: astral-sh/setup-uv@v5
- name: Install Dependencies
if: ${{ matrix.os == 'ubuntu-latest' }}
run: sudo apt-get update && sudo apt-get install xvfb
timeout-minutes: 1
- name: Install Dependencies on Ubuntu
if: ${{ startsWith(matrix.os, 'ubuntu-') }}
run: >
sudo apt-get update &&
sudo apt-get install xvfb
libnss3 libatk-bridge2.0-0 libcups2 libxcomposite1 libxdamage1
libxfixes3 libxrandr2 libgbm1 libxkbcommon0 libpango-1.0-0
libcairo2
timeout-minutes: 3
- name: Install Chrome on Ubuntu-Arm
if: ${{ matrix.os == 'ubuntu-24.04-arm' }}
run: sudo apt-get install chromium-browser && chromium --version
timeout-minutes: 3
# must actually checkout for version determination
- run: git checkout ${{ github.ref_name }}
- run: uv python install ${{ matrix.python_v }}
Expand All @@ -37,6 +46,7 @@ jobs:
run --no-sync --with setuptools-git-versioning
setuptools-git-versioning)-py3-none-any.whl
- run: uv run --no-sync choreo_get_chrome -v #--i ${{ matrix.chrome_v }}
if: ${{ matrix.os != 'ubuntu-24.04-arm' }}
- name: Diagnose
run: uv run --no-sync choreo_diagnose --no-run
- name: Test
Expand Down
23 changes: 17 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,33 @@ jobs:
test-all:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-latest, macos-latest, ubuntu-24.04-arm]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- uses: astral-sh/setup-uv@v5
- uses: actions/setup-python@v5
with:
python-version-file: "pyproject.toml"

- name: Install Dependencies
if: ${{ matrix.os == 'ubuntu-latest' }}
run: sudo apt-get update && sudo apt-get install xvfb
timeout-minutes: 1
- name: Install Dependencies on Ubuntu
if: ${{ startsWith(matrix.os, 'ubuntu-') }}
run: >
sudo apt-get update &&
sudo apt-get install xvfb
libnss3 libatk-bridge2.0-0 libcups2 libxcomposite1 libxdamage1
libxfixes3 libxrandr2 libgbm1 libxkbcommon0 libpango-1.0-0
libcairo2
timeout-minutes: 3
- name: Install Chrome on Ubuntu-Arm
if: ${{ startsWith(matrix.os, 'ubuntu-') }}
#if: ${{ matrix.os == 'ubuntu-24.04-arm' }}
run: sudo apt-get install chromium-browser && chromium --version
timeout-minutes: 3
- name: Install choreographer
run: uv sync --no-sources --all-extras
- name: Install google-chrome-for-testing
if: ${{ ! startsWith(matrix.os, 'ubuntu-') }}
# if: ${{ matrix.os != 'ubuntu-24.04-arm' }}
run: uv run --no-sources choreo_get_chrome -v
- name: Diagnose
run: uv run --no-sources choreo_diagnose --no-run
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ repos:
}\
}"]
- repo: https://github.com/rhysd/actionlint
rev: v1.7.4
rev: v1.7.7
hooks:
- id: actionlint
name: Lint GitHub Actions workflow files
Expand Down
Loading