Skip to content

[v9] fix(createPortal): ensure container is wrapped in Scene #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 269 commits into
base: master
Choose a base branch
from
Open

[v9] fix(createPortal): ensure container is wrapped in Scene #3247

wants to merge 269 commits into from

Conversation

CodyJasonBennett
Copy link
Member

Fixes #2725.

krispya and others added 30 commits May 30, 2022 12:01
@krispya
Add Stages enum. Checks are runtime. Also added an example for extend…
a01e9b2 
…ing the enum
@krispya
Merge branch 'exp/update' of https://github.com/krispya/react-three-f…
4a1a61a 
…iber into exp/update
@krispya
Documentation added. Standard renamed to StandardStages to be more ex…
c4ffe0d 
…plicit
@CodyJasonBennett
Merge branch 'master' into pr/2279
04778e4
@krispya
Convert FixedStage to use getters and setters
7776cf5
@krispya
Use instance objects to identify stage updates
24e25ca
@krispya
Simplify Update example
2e901c0
@krispya
Cleaned up remaining stage name code. Made sure delta cannot go below 0
9a72afd
@krispya
Made useUpdate's exception make more sense
36dbefe
@krispya
The frameloop prop now accepts an object and legacy string
23cd91b
@krispya
Simplify FixedState parameters
3931802
@krispya
Revert "Turn prettier off in eslint"
406263a 
This reverts commit f23ecaf.
@krispya
Clean up example
5cc8be5
@krispya
useUpdate throws an Error instead of a string
9f921c7
@krispya
Merge branch 'master' into exp/update
565d031
@krispya
feat: Stages has a delta that measures how long it took to execute. F…
b1502e0 
…ixedStages also has substepDeltas returning an array of deltas for each substep
@krispya
Remove bad comment
b086e6a
@krispya
refactor(FixedStage): Remove while look failsafe. It used arbitrary v…
1775dc1 
…alues and now that we have deltas there are useland ways to hanlde this
@krispya
refactor(stages): Rename delta to frameTime
9746c05
@krispya
refactor(FixedStage): Rename substepFrameTime to substepTimes
aa7c81f
@CodyJasonBennett
chore: bump to 9.0.0-alpha.0
57829d4
@krispya
Merge branch 'pmndrs:master' into exp/update
0bdb6bd
@krispya
Merge pull request #2279 from krispya/exp/update
8500cbd 
feat: implement update lifecycle with useUpdate
@CodyJasonBennett
Merge branch 'master' into v9
2e7497f
@CodyJasonBennett
Merge branch 'master' into v9
43b82f3
@CodyJasonBennett
[v9] refactor(core)!: always set colormanagement, use r141 WebXR types (
5c9544f 
#2377)
@CodyJasonBennett
chore: fix lint
5860b5c
@CodyJasonBennett
chore: bump native deps
f9fb114
@CodyJasonBennett
Merge branch 'master' into v9
242e76b
@hmans
refactor(Canvas)!: rename Props to CanvasProps (#2434)
b88631e
CodyJasonBennett and others added 25 commits April 27, 2024 16:34
@CodyJasonBennett
fix(types): use new createWithEqualityFn signature
f2de25c
@CodyJasonBennett
fix(types): shim OffscreenCanvas
ad0e822 
Mirrors DefinitelyTyped/DefinitelyTyped#54988
@CodyJasonBennett
fix(findInitialRoot): restore traverse, add coverage
eafb2cc
@CodyJasonBennett
chore(demos): cleanup SVGRenderer
b252c8a
@CodyJasonBennett
chore: cleanup
817335b
@CodyJasonBennett
chore(demos): upgrade deps
b62c807
@CodyJasonBennett
[v9] refactor!: remove viewport, add dpr (#2887)
d7eb077
@krispya
chore: Use React beta typings
538a89a
@krispya
Merge branch 'v9' of https://github.com/pmndrs/react-three-fiber into v9
a4a86c4
@krispya
fix: JSX namespacing for v19
d7f7ed4
@CodyJasonBennett
fix(types): use new ref type
0ffa718
@CodyJasonBennett
fix(types): resolve remaining type issues
e0f8a3a
@krispya
chore: replace ts-ignore with ts-expect-error
bcc0620
@CodyJasonBennett
chore(tests): add failing suspense case
f1a296d
@CodyJasonBennett
fix(reconciler): don't implement (un)hideInstance methods (#3241)
eafe554
@CodyJasonBennett
RELEASING: Releasing 2 package(s)
a17fe45 
Releases:
  @react-three/fiber@9.0.0-alpha.4
  @react-three/test-renderer@9.0.0-alpha.4

[skip ci]
@CodyJasonBennett
chore(hooks): cleanup
0d8d270
@CodyJasonBennett
Merge branch 'master' into v9
77fd711
@CodyJasonBennett
chore: resolve conflicts
1141515
@krispya
fix(reconciler): instances were not being unhidden properly
5a076d9
@CodyJasonBennett
chore: cleanup
f6e4c46
@CodyJasonBennett
chore: re-use (un)hide hooks
6607d4d
@CodyJasonBennett
fix: swapped hide/unhide
03c823b
@krispya
test: suspense visibility
f6325a6
@CodyJasonBennett
fix(createPortal): ensure container is wrapped in Scene
8a52be0
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 1, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d92501c:

Sandbox Source
example Configuration

CodyJasonBennett
CodyJasonBennett commented May 1, 2024
View reviewed changes
@krispya
Copy link
Member

krispya commented May 3, 2024

I think a better solution is to have scene always point to the root scene, which I think is expected behavior, and then add another prop to the store called container or root that points to the portal root. When not in a portal it would just be the same as scene. This way you always have full access to the tree even if inside of a portal.

Base automatically changed from v9 to master February 19, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@CodyJasonBennett @krispya @hmans @drcmda @AlaricBaraou @charliefuller @AbsharHassan @itsdouges @satelllte