Potential fix for bug #5010 #5024
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for trying to fix this @reshmee011. but did you actually test your suggested code and did it work? If I'm trying here, it doesn't work. This is because PnP Core, which is responsible for retrieving the actual file contents behind the scenes, messes with the URL and replaces the %20 with a space: I don't see an easy way to fix this without making things really messy in the code. |
|
I thought I got it working it before submitting the PR, it's not working anymore for me too. I was not convinced with the fix was the best forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #5010
What is in this Pull Request ?
A switch parameter NoUrlDecode to skip URL decoding of file name to cater for %20 within filename.