-
Notifications
You must be signed in to change notification settings - Fork 10
POD-156: Feat/bridge #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
POD-156: Feat/bridge #125
Conversation
…ry-validator-administration
- Add functions for activating / deactivating validators - Add a function for initializing a validator - Refactor methods to use the functions - Rename nextValidatorIndex to validatorCount and derive index from it - Add tests compute weight when subset is larger than 255 and test ban not creating a snapshot when the banned validator is inactive
…ry-validator-administration
… to index in params
…ngs, revert test to Test
…ry-validator-administration
72f89ac
to
6f7badb
Compare
…d test tokens, update bridge to return id
|
||
let (request_id, token_address, block_number) = | ||
source_chain_bridge_client.deposit_token(to, amount).await?; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd have to wait here for block_number to be finalized... repeatedly query get_block_by_number with finalized parameter and compare block_number to the response.block_number
|
||
let (request_id, source_chain_block_number) = | ||
source_chain_bridge_client.deposit_native(to, value).await?; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too, wait for block number to be finalized when on sepolia/ethereum
Bridge Implementation: Mint-Burn and Deposit-Withdraw Patterns
Overview
This PR implements a cross-chain token bridging system with two contracts: mint-burn and deposit-withdraw. The implementation includes complete contracts, interfaces, test suites, and documentation.
Architecture
Abstract Bridge Contract
Bridge.sol
with abstract methods for concrete implementationsTwo Bridge Implementations
1. BridgeMintBurn
eth_getLogs
verificationcreateAndWhitelistMirrorToken
for token whitelisting / creation2. BridgeDepositWithdraw
Testing
Added tests that cover the functionality of the bridge
Documentation Improvements