feat: improve task polling #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements an improved task polling mechanism with configurable wait time. This helps to minimize resource consumption on the Connect server while still providing responsive feedback.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
aronatkins
approved these changes
May 7, 2025
src/posit/connect/tasks.py
Outdated
| backoff : float, default 1.5 | ||
| Backoff multiplier for increasing wait times. | ||
| wait : int, default 1 | ||
| Wait time in seconds between polling requests. |
There was a problem hiding this comment.
Suggested change
| Wait time in seconds between polling requests. | |
| Maximum amount of time for the task API request to capture status changes. |
There was a problem hiding this comment.
I don't love my suggested wording, either.
There was a problem hiding this comment.
Added a notes section going into more detail.
|
Added a maximum attempts option so folks can break out of the loop if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an improved task polling mechanism with configurable wait time. This helps to minimize resource consumption on the Connect server while still providing responsive feedback.
Resolves #184